Updated configuration.md for missing config properties

[shivamshriwas]

Description

Added missing config properties in configuration.md
Added an note on use of enable_envvars_config.
Modifed MODEL_SERVER_HOME env variable to TS_MODEL_SERVER_HOME to make it inline with other config properties which can be set using env vars.

Fixes #204

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• This change requires a documentation update

Feature/Issue validation/testing

• Test A
  set enable_envvars_config true in config.properties
  Use env variable to set config property. (refer configuration.md)
  Observe use of env variable in torchserve instance.

• UT/IT execution results

• Logs

• [
  issue_204_torchserve_sanity_log.txt

Checklist:

] Have you added tests that prove your fix is effective or that this feature works?

• New and existing unit tests pass locally with these changes?
• Has code been commented, particularly in hard-to-understand areas?
• Have you made corresponding changes to the documentation?

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-cpu
• Commit ID: ba630c5
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-gpu
• Commit ID: ba630c5
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-cpu
• Commit ID: acd2269
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-gpu
• Commit ID: acd2269
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-cpu
• Commit ID: d8ca5e1
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-gpu
• Commit ID: d8ca5e1
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[maaquib]

Running into the following exception when testing this.
Steps for reproduction:

> cat /tmp/serve/config.properties
debug=true
model_store=/tmp/model-store
model_server_home=/tmp/model-server-home
max_request_size=1000000
max_response_size=1

> torchserve --start --ts-config config.properties

> curl -X POST "http://127.0.0.1:8081/models?url=https://torchserve.s3.amazonaws.com/mar_files/squeezenet1_1.mar"
{
  "status": "Model \"squeezenet1_1\" registered"
}

> curl -X PUT "http://0.0.0.0:8081/models/squeezenet1_1?min_worker=3"
{
  "status": "Processing worker updates..."
}

2020-05-20 00:07:23,814 [INFO ] epollEventLoopGroup-3-1 org.pytorch.serve.wlm.ModelManager - Model squeezenet1_1 loaded.
2020-05-20 00:07:26,880 [DEBUG] epollEventLoopGroup-3-2 org.pytorch.serve.wlm.ModelManager - updateModel: squeezenet1_1, count: 3
2020-05-20 00:07:26,886 [DEBUG] W-9000-squeezenet1_1_1.0 org.pytorch.serve.wlm.WorkerThread - W-9000-squeezenet1_1_1.0 State change null -> WORKER_STARTED
2020-05-20 00:07:26,886 [DEBUG] W-9000-squeezenet1_1_1.0 org.pytorch.serve.wlm.WorkerThread - W-9000-squeezenet1_1_1.0 State change null -> WORKER_STARTED
2020-05-20 00:07:26,886 [DEBUG] W-9000-squeezenet1_1_1.0 org.pytorch.serve.wlm.WorkerThread - W-9000-squeezenet1_1_1.0 State change null -> WORKER_STARTED
2020-05-20 00:07:26,888 [INFO ] W-9000-squeezenet1_1_1.0 org.pytorch.serve.wlm.WorkerThread - Connecting to: /tmp/.ts.sock.9000
2020-05-20 00:07:26,888 [INFO ] W-9000-squeezenet1_1_1.0 org.pytorch.serve.wlm.WorkerThread - Connecting to: /tmp/.ts.sock.9000
2020-05-20 00:07:26,888 [INFO ] W-9000-squeezenet1_1_1.0 org.pytorch.serve.wlm.WorkerThread - Connecting to: /tmp/.ts.sock.9000
2020-05-20 00:07:26,894 [ERROR] W-9000-squeezenet1_1_1.0 org.pytorch.serve.wlm.WorkerThread - Backend worker error
org.pytorch.serve.wlm.WorkerInitializationException: Failed to connect to worker.
>-------at org.pytorch.serve.wlm.WorkerThread.connect(WorkerThread.java:289)
>-------at org.pytorch.serve.wlm.WorkerThread.run(WorkerThread.java:120)
>-------at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
>-------at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
>-------at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
>-------at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
>-------at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: java.io.FileNotFoundException
>-------at io.netty.channel.unix.Errors.throwConnectException(Errors.java:110)
>-------at io.netty.channel.unix.Socket.connect(Socket.java:257)
>-------at io.netty.channel.epoll.AbstractEpollChannel.doConnect0(AbstractEpollChannel.java:732)
>-------at io.netty.channel.epoll.AbstractEpollChannel.doConnect(AbstractEpollChannel.java:717)
>-------at io.netty.channel.epoll.EpollDomainSocketChannel.doConnect(EpollDomainSocketChannel.java:87)
>-------at io.netty.channel.epoll.AbstractEpollChannel$AbstractEpollUnsafe.connect(AbstractEpollChannel.java:559)
>-------at io.netty.channel.DefaultChannelPipeline$HeadContext.connect(DefaultChannelPipeline.java:1366)
>-------at io.netty.channel.AbstractChannelHandlerContext.invokeConnect(AbstractChannelHandlerContext.java:545)
>-------at io.netty.channel.AbstractChannelHandlerContext.connect(AbstractChannelHandlerContext.java:530)
>-------at io.netty.channel.ChannelOutboundHandlerAdapter.connect(ChannelOutboundHandlerAdapter.java:47)
>-------at io.netty.channel.AbstractChannelHandlerContext.invokeConnect(AbstractChannelHandlerContext.java:545)
>-------at io.netty.channel.AbstractChannelHandlerContext.connect(AbstractChannelHandlerContext.java:530)
>-------at io.netty.channel.AbstractChannelHandlerContext.connect(AbstractChannelHandlerContext.java:512)
>-------at io.netty.channel.DefaultChannelPipeline.connect(DefaultChannelPipeline.java:1024)
>-------at io.netty.channel.AbstractChannel.connect(AbstractChannel.java:259)
>-------at io.netty.bootstrap.Bootstrap$3.run(Bootstrap.java:252)
>-------at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:163)
>-------at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:404)
>-------at io.netty.channel.epoll.EpollEventLoop.run(EpollEventLoop.java:309)
>-------at io.netty.util.concurrent.SingleThreadEventExecutor$5.run(SingleThreadEventExecutor.java:884)
>-------at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
>-------... 1 more

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-cpu
• Commit ID: b3f3db2
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-gpu
• Commit ID: b3f3db2
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-cpu
• Commit ID: e5184ca
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-gpu
• Commit ID: e5184ca
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[shivamshriwas]

@shivamshriwas Can you also take a look at the min_worker scaling issue that I reported. If it is not related to your change, I'll create a separate issue. Thanks.

@maaquib
the issue here is not due to changes in this PR , its debug mode specific which is not intended to use as steps followed.
debug option is developer specific property hence as discussed removed from main doc.
issue #215 will be taking care of adding documentation around it.

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-cpu
• Commit ID: 5b8fe71
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-gpu
• Commit ID: 5b8fe71
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-cpu
• Commit ID: 29dfd93
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-gpu
• Commit ID: 29dfd93
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-cpu
• Commit ID: 3456e29
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-gpu
• Commit ID: 3456e29
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-cpu
• Commit ID: 1af405b
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[maaquib]

Verified that this is working as expected after removing debug. The debug flag documentation has been removed from here and will be added to a seprate Developer documentation as per #215

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-gpu
• Commit ID: 1af405b
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-cpu
• Commit ID: 1af405b
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[sagemaker-neo-ci-bot]

AWS CodeBuild CI Report

• CodeBuild project: torch-serve-build-gpu
• Commit ID: 1af405b
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[datavistics]

Its called max_request_size in the config.properties file.
Here is what Im using:
max_request_size=999999999