add stubs for m3u8 #12683
Open
add stubs for m3u8 #12683
+623
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
srittau
reviewed
Sep 23, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srittau
reviewed
Sep 24, 2024
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
requested changes
Sep 30, 2024
| @@ -0,0 +1,27 @@ | |||
| # mypy: disable-error-code="attr-defined" | |||
There was a problem hiding this comment.
Why is this necessary. In general, we prefer # type: ignore[attr-defined] on the lines that this actually affects.
|
|
||
| _T = TypeVar("_T") | ||
|
|
||
| class BasePathMixin(Protocol): |
There was a problem hiding this comment.
As this is not a protocol at runtime, it shouldn't be a protocol here either.
Comment on lines
+14
to
+16
| @type_check_only | ||
| class _PlaylistProtocol(BasePathMixin, metaclass=ABCMeta): | ||
| base_uri: str | None |
There was a problem hiding this comment.
To make this then work correctly, it should be changed to:
Suggested change
| @type_check_only | |
| class _PlaylistProtocol(BasePathMixin, metaclass=ABCMeta): | |
| base_uri: str | None | |
| @type_check_only | |
| class _PlaylistProtocol(Protocol): | |
| base_uri: str | None | |
| uri: str | None | |
| @property | |
| def absolute_uri(self) -> str: ... | |
| @property | |
| def base_path(self) -> str: ... | |
| @base_path.setter | |
| def base_path(self, newbase_path: str) -> None: ... | |
| def get_path_from_uri(self) -> str: ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.