Update the PR template and Contributing Guidelines #738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mention about signing the CLA, and additional steps before writing up a PEP. Closes python#158
|
Should the PR template also mention that there's a checklist to be completed before submitting in the contributing guidelines? Or just include that checklist within the PR template, as originally proposed? |
brettcannon
approved these changes
Jul 13, 2018
|
@pradyunsg it should be one or the other, but not both as that leads to skew. For now we can leave it as @Mariatta implemented it and see how it goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mention about signing the CLA, and additional steps before writing up a PEP.
I copied over text from
#158 (comment)
and
#158 (comment)
Closes #158