Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename all .txt PEP files to .rst #462

Merged
merged 1 commit into from
Nov 11, 2017

Conversation

mozillazg
Copy link
Contributor

Only rename files, others PR will update pep2html.py and pep0.

@Mariatta Mariatta merged commit bb0e518 into python:master Nov 11, 2017
@Mariatta
Copy link
Member

Thanks @mozillazg!

Mariatta added a commit to Mariatta/peps that referenced this pull request Nov 11, 2017
Mariatta added a commit that referenced this pull request Nov 11, 2017
@Mariatta
Copy link
Member

Sorry @mozillazg. After I merged your PR, it erased the history of the PEPs; each pep-*.rst was treated as a brand new file. So I had to revert your changes to retain the history.

@methane
Copy link
Member

methane commented Nov 11, 2017 via email

@Mariatta
Copy link
Member

@methane, sorry, 'erased' was the wrong word I shouldn't have used it. What happened was that when a file was renamed, GitHub is only showing the new file history since the rename. So after pep-0008.txt was renamed to pep-0008.rst, on GitHub I could no longer see all the revision ever made to PEP 8.
On the command line, git log pep-0008.rst also does not show the complete revision history. Only that it was renamed. We have to do git log --follow pep-0008.rst to get the complete history.
I think not being able to easily see the history in GitHub is inconvenient and I'm not comfortable with it.
So I reverted the commit for now. (everything is in . txt again).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants