runtests.py: list tests to run in typeshed CI #9638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running a subset of tests will help speed up typeshed CI. I don't think typeshed really benefits from running all the other tests. Worst case if something breaks, it'll be caught when typeshed is synced in mypy.
JukkaL
reviewed
Oct 27, 2020
| @@ -79,6 +79,8 @@ | |||
| MYPYC_EXTERNAL, | |||
| MYPYC_COMMAND_LINE, | |||
| ERROR_STREAM]), | |||
| # Test cases to run in typeshed CI | |||
| 'typeshed-ci': 'pytest -k "%s"' % ' or '.join([CMDLINE, EVALUATION, SAMPLES, TYPESHED]), | |||
There was a problem hiding this comment.
Also update DEFAULT_COMMANDS below to not include this (or maybe get rid of it, since it's super error-prone, and use a flag here or something).
hauntsaninja
pushed a commit
to hauntsaninja/typeshed
that referenced
this pull request
Oct 27, 2020
Only a subset of mypy's test suite should be relevant to typeshed: python/mypy#9638 This should make things faster. (Also the -n12 argument to pytest is weird; note mypy's pytest.ini automatically specificies -nauto which is what we should want) Resolves python#4333
srittau
pushed a commit
to python/typeshed
that referenced
this pull request
Oct 28, 2020
Only a subset of mypy's test suite should be relevant to typeshed: python/mypy#9638 This should make things faster. (Also the -n12 argument to pytest is weird; note mypy's pytest.ini automatically specificies -nauto which is what we should want) Resolves #4333 Co-authored-by: hauntsaninja <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running a subset of tests will help speed up typeshed CI. I don't think
typeshed really benefits from running all the other tests. Worst case if
something breaks, it'll be caught when typeshed is synced in mypy.