stubtest: speed up tests by a lot #9621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I probably should have done this earlier...
ethanhs
reviewed
Oct 21, 2020
Co-authored-by: Ethan Smith <[email protected]>
hauntsaninja
pushed a commit
to hauntsaninja/mypy
that referenced
this pull request
Oct 24, 2020
I did some work to speed up stubtest tests substantially in python#9621 This is a lesser win. The argument to get rid of it is that it's the slowest mypy test and just testing for crashes on typeshed doesn't provide much value. Since this was written we started running stubtest in typeshed CI and in practice all changes are tested on typeshed anyway.
hauntsaninja
added a commit
that referenced
this pull request
Oct 25, 2020
I did some work to speed up stubtest tests substantially in #9621 This is a lesser win. The argument to get rid of it is that it's the slowest mypy test and just testing for crashes on typeshed doesn't provide much value. Since this was written we started running stubtest in typeshed CI and in practice all changes are tested on typeshed anyway. Co-authored-by: hauntsaninja <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I probably should have done this earlier...