Categorize some stubgen tests as slow tests #6340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows pytest to parallelize tests more effectively and seems to make the test suite faster by ~5 seconds or so on my Linux desktop. These can use typeshed so they are not fast tests. Some of the StubgenPython tests are fast but others aren't. I'm classifying them as slow since it looks like this is generally better for scheduling, but it might be even better to split the suite into fast and slow parts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows pytest to parallelize tests more effectively and
seems to make the test suite faster by ~5 seconds or so on my
Linux desktop.
These can use typeshed so they are not fast tests.
Some of the StubgenPython tests are fast but others aren't. I'm
classifying them as slow since it looks like this is generally
better for scheduling, but it might be even better to split the
suite into fast and slow parts.