Now that typed_ast 1.3.0 is released, mandate it #6270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msullivan
approved these changes
Jan 30, 2019
ethanhs
approved these changes
Jan 30, 2019
msullivan
pushed a commit
that referenced
this pull request
Jan 31, 2019
(In both setup.py and test-requirements.txt.)
|
Is typed_ast safe or an improvement for mypy 0.660? I noticed some Py3.7 fixes That is, should I update the typed-ast package in Debian before the final freeze for their upcoming release of Debian Buster? Debian Buster is only shipping Python 3.7 of the Python 3 series.. |
|
In general you won't notice much of a difference. But for mypy 0.670 we'll require typed_ast 1.3.x, so you might as well get on that train. |
|
Since Buster is only shipping 3.7, and a goal of typed_ast is to be bug-for-bug compatible, I think it would be better to use typed_ast 1.3.x, since the newer typed_ast has better compatibility with (and is based on) the 3.7 ast module. Though if you do, you should probably bump mypy to 0.670 when it is released (hopefully this Friday). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.