Disable coverage during CI runs until we can figure out how to make i… #2328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t not such a performance penalty
Merged
ddfisher
reviewed
Oct 25, 2016
| - coverage erase | ||
| - python runtests.py --coverage | ||
| - coverage combine | ||
| - python runtests.py | ||
|
|
||
| after_success: | ||
| - bash <(curl -s https://codecov.io/bash) |
There was a problem hiding this comment.
Does this line need to be removed too?
There was a problem hiding this comment.
Yup. I'll remove it (I can edit PRs).
|
Yup. I realized it as soon as I walked out of the office. On Tue, Oct 25, 2016, 5:07 PM David Fisher [email protected] wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t not such a performance penalty