Add regression test cases #17869
Merged
Add regression test cases #17869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # https://github.com/python/mypy/issues/17864 | ||
| def f(x: str | int) -> None: | ||
| if x == "x": | ||
| reveal_type(x) # N: Revealed type is "Union[builtins.str, builtins.int]" |
There was a problem hiding this comment.
Is this desired behavior? I feel like we should narrow to Literal["x"]. Yes, it might be a subclass of int that compares equal with str, but don't do that.
There was a problem hiding this comment.
Yeah, this case seems fine. But classes that compare equal to int are not unusual (e.g. Decimal), so it's not clear where to draw the line. We might need some ad-hoc rules to support common use cases.
There was a problem hiding this comment.
The last time I tried that change IIRC it looked pretty good on primer, I think the main obstacle was it exposed some shortcomings in the binder
JelleZijlstra
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17864