Fix types.GenericAlias lookup crash #17543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
Not related to your change but the return of typing._SpecialForm just below should also return types.GenericAlias. The change itself looks right. |
|
Yeah, good point. I'll try changing that in a follow-up, since we'll probably want to backport this PR |
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JelleZijlstra
approved these changes
Jul 20, 2024
hauntsaninja
added a commit
to hauntsaninja/mypy
that referenced
this pull request
Jul 20, 2024
Mentioned by Jelle in python#17543 (comment)
This was referenced Jul 20, 2024
hauntsaninja
added a commit
that referenced
this pull request
Jul 20, 2024
Mentioned by Jelle in #17543 (comment)
jwodder
added a commit
to dandi/dandi-cli
that referenced
this pull request
Jul 23, 2024
Broken on Python 3.8: python/mypy#17543
hauntsaninja
added a commit
that referenced
this pull request
Jul 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17542