Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete recursive aliases flags #16346

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

ilevkivskyi
Copy link
Member

FWIW I decided to keep the old tests (where possible), just to be sure we will not re-introduce various crashes at function scope, where recursive aliases are not allowed.

@github-actions
Copy link
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

discord.py (https://github.com/Rapptz/discord.py): typechecking got 1.10x faster (171.2s -> 155.5s)
(Performance measurements are based on a single noisy sample)

@ilevkivskyi ilevkivskyi merged commit 9011ca8 into python:master Oct 27, 2023
18 checks passed
@ilevkivskyi ilevkivskyi deleted the delete-old-aliases-flag branch October 27, 2023 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants