Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tox.ini to sdist #15853

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Add tox.ini to sdist #15853

merged 1 commit into from
Aug 12, 2023

Conversation

mtelka
Copy link
Contributor

@mtelka mtelka commented Aug 11, 2023

Fixes #14142

@github-actions

This comment has been minimized.

Sign in to view
hauntsaninja
hauntsaninja requested changes Aug 12, 2023
View reviewed changes
Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, can you remove tox.ini from the exclude on L45?

@github-actions
Copy link
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

@hauntsaninja hauntsaninja merged commit 7f22aaa into python:master Aug 12, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The sdist is missing tox.ini
2 participants
@mtelka @hauntsaninja