Fix testLiteralMeets failure #15659
Merged
Fix testLiteralMeets failure #15659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👁️ @sobolevn |
sobolevn
reviewed
Jul 13, 2023
| @@ -1797,7 +1797,8 @@ def f5(x: Literal[1], y: Union[Literal[1], Literal[2]]) -> None: pass | |||
| def f6(x: Optional[Literal[1]], y: Optional[Literal[2]]) -> None: pass | |||
|
|
|||
| reveal_type(unify(f1)) # N: Revealed type is "Literal[1]" | |||
| reveal_type(unify(f2)) # N: Revealed type is "<nothing>" | |||
| if object(): | |||
There was a problem hiding this comment.
This seems like a regression to me, because this is not "really <nothing>, execution is stopped", it is just "we cannot do a better job with two literal values".
In the long run we need to figure out how to tell these two cases apart.
There was a problem hiding this comment.
This was always the case for function scope. I only made module scope work the same way.
I agree that entire behavior leaves a lot to be desired, and I'll try to work on that next.
(Fwiw, it's also broken that "cannot call function of unknown type" is treated differently than "expression has uninhibited type".)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #15386, any uninhabited type in module scope causes the rest of the block to go unchecked.
Fixes #15657.