Switch PEP 561 tests to a different build backend #15451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes python#15446 setuptools has broken how editable installs work. It seems like most other build backends continue to use static pth files, so let's just switch to another one.
|
Oh interesting, I guess whatever pip + setuptools combination ships with Python 3.7 is too old to support PEP 660. I'll just skip the test on 3.7... |
hauntsaninja
force-pushed
the
pep561-tests
branch
from
a4239e5
to
c8c2150
Compare
JukkaL
approved these changes
Jun 16, 2023
There was a problem hiding this comment.
Thanks for fixing this! I don't have a ton of context on what is going on here, but since the build is failing on master, I'm going to merge this anyway. If this PR has some issues, we can forward fix them once master is green again.
It would be great if somebody else can have another look after this has been merged (@ethanhs perhaps?).
hauntsaninja
added a commit
that referenced
this pull request
Jun 24, 2023
Fixes #15446 setuptools has broken how editable installs work. It seems like most other build backends continue to use static pth files, so let's just switch to another one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15446
setuptools has broken how editable installs work. It seems like most other build backends continue to use static pth files, so let's just switch to another one.