Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use X | Y union syntax in error messages #15102

Merged
merged 8 commits into from
Apr 24, 2023
Merged

Use X | Y union syntax in error messages #15102

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
08d0082
Display union items with | on error
omarsilva1 Apr 22, 2023
1302eb8
Merge remote-tracking branch 'mypy-fork/master' into union-error-syntax
omarsilva1 Apr 22, 2023
2d8120f
Fix formatting
omarsilva1 Apr 23, 2023
3ea528a
Add python 3.8 flag to daemon
omarsilva1 Apr 23, 2023
88f34c2
Merge branch 'master' into union-error-syntax
omarsilva1 Apr 23, 2023
15412db
Add or formatting for union
omarsilva1 Apr 24, 2023
f1179d0
Merge branch 'master' into union-error-syntax
omarsilva1 Apr 24, 2023
5de6662
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix formatting
  • Loading branch information
@omarsilva1
omarsilva1 committed Apr 23, 2023
commit 2d8120f2858368b785336bff7665c8f2b96e539a
8 changes: 4 additions & 4 deletions mypy/messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2360,10 +2360,10 @@ def format_list(types: Sequence[Type]) -> str:
return ", ".join(format(typ) for typ in types)

def format_union(types: Sequence[Type]) -> str:
new_list = [format(typ) for typ in types if format(typ) is not "None"]
if any(format(typ) is "None" for typ in types):
new_list.append("None")
return " | ".join(new_list)
formatted = [format(typ) for typ in types if format(typ) != "None"]
if any(format(typ) == "None" for typ in types):
formatted.append("None")
return " | ".join(formatted)

def format_literal_value(typ: LiteralType) -> str:
if typ.is_enum_literal():
Expand Down