Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stubinfo: remove two obsolete packages #14842

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

JelleZijlstra
Copy link
Member

Fixes #14841.

types-backports is obsolete and leads to incorrect suggestions; see the issue.

types-backports_abc was removed from typeshed in python/typeshed#7533.

Copy link
Collaborator

@hauntsaninja hauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning this up!

@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

Diff from mypy_primer, showing the effect of this PR on open source code:

sublime_debugger (https://github.com/daveleroy/sublime_debugger)
- modules/libs/pywinpty/st3_windows_x64/winpty/ptyprocess.py:17: error: Library stubs not installed for "backports.shutil_which"  [import]
+ modules/libs/pywinpty/st3_windows_x64/winpty/ptyprocess.py:17: error: Cannot find implementation or library stub for module named "backports.shutil_which"  [import]
- modules/libs/pywinpty/st3_windows_x32/winpty/ptyprocess.py:17: error: Library stubs not installed for "backports.shutil_which"  [import]
+ modules/libs/pywinpty/st3_windows_x32/winpty/ptyprocess.py:17: error: Cannot find implementation or library stub for module named "backports.shutil_which"  [import]
- modules/libs/pywinpty/st3_windows_x32/winpty/ptyprocess.py:17: note: Hint: "python3 -m pip install types-backports"
- modules/libs/pywinpty/st3_windows_x32/winpty/ptyprocess.py:17: note: (or run "mypy --install-types" to install all missing stub packages)

@hauntsaninja
Copy link
Collaborator

Nice, shows up on primer as well!

@hauntsaninja hauntsaninja merged commit da6e4a0 into python:master Mar 6, 2023
@JelleZijlstra JelleZijlstra deleted the nobac branch March 6, 2023 06:13
@JelleZijlstra JelleZijlstra restored the nobac branch September 10, 2024 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong recommendation to install types-backports
2 participants