Improve protocols documentation #14577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| :py:func:`isinstance` with protocols is not completely safe at runtime. | ||
| For example, signatures of methods are not checked. The runtime | ||
| implementation only checks that all protocol members are defined. | ||
| implementation only checks that all protocol members exist, |
There was a problem hiding this comment.
It also doesn't check attributes at all, only methods, if I recall correctly. That might be worth mentioning.
There was a problem hiding this comment.
isinstance() checks both, but issubclass() checks only methods.
Co-authored-by: Jelle Zijlstra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linking #13681