tox: Remove outdate coverage targets #13520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
CONTRIBUTING.md
Outdated
| @@ -76,6 +82,12 @@ flake8 | |||
| black . && isort . | |||
| ``` | |||
|
|
|||
| To run tests with coverage: | |||
There was a problem hiding this comment.
Can we move this to test-data/unit/README.md?
CONTRIBUTING.md is aimed at newer contributors; I don't think many of them will be running coverage
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were so many things from with this:
covcommand (the second one afterpytest) was never executed, since you needed to call it explicitly withtox -e py38-cov. But, in this case it was generated after the initial test run. So, basically you had two test runs to get coveragecoverageenvironment was just broken. For example, all packages are very outdateddiff-coveris at6.5right now, while we had it pinned to<2. It tried to make it work, but no luck. After all, I don't think that we really need this undocumented and unused way of getting coverageCONTRIBUTING.mdfile