AssignmentExpr is not a BindableExpression #13483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Aug 23, 2022
|
|
||
| def get_things() -> Union[Tuple[Good], Tuple[Bad]]: ... | ||
|
|
||
| if (things := get_things())[0].is_good: |
There was a problem hiding this comment.
You have modified two branches for IndexExpr and MemberExpr, but this new test covers NameExpr. Do we have other two covered?
There was a problem hiding this comment.
Good point, I'll fix this tomorrow.
There was a problem hiding this comment.
The tomorrow has just started in my timezone 😆
(Well, actually 1/2 of tomorrow has already passed 😞)
There was a problem hiding this comment.
this new test covers NameExpr
The new test actually covers IndexExpr in the branch above.
I tried adding tests with IndexExpr and MemberExpr inside the walrus, but it turns out that's not valid Python
This comment has been minimized.
This comment has been minimized.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
sobolevn
approved these changes
Aug 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.