New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix testNonBooleanContainsReturnValue #10677

Merged

JelleZijlstra merged 1 commit into python:master from ikonst:fix-testNonBooleanContainsReturnValue

Jun 20, 2021

Contributor

ikonst commented Jun 20, 2021 •

edited

Loading

testNonBooleanContainsReturnValue is testing that in always evaluates as bool (per #5688).

This test worked due to fixture's lack of knowledge that issubclass(bool, int). To more correctly test, let's use distinct types bool and str.


          Fix testNonBooleanContainsReturnValue

f97ba65

JelleZijlstra approved these changes

View reviewed changes

JelleZijlstra merged commit 4386289 into python:master

ikonst deleted the fix-testNonBooleanContainsReturnValue branch

June 20, 2021 04:08

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet