Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-98331: Update bundled pip to 22.3 #98332

Merged
merged 2 commits into from
Oct 18, 2022
Merged

gh-98331: Update bundled pip to 22.3 #98332

merged 2 commits into from
Oct 18, 2022

Conversation

pfmoore
Copy link
Member

@pfmoore pfmoore commented Oct 16, 2022

@pfmoore
Copy link
Member Author

pfmoore commented Oct 16, 2022

@pablogsal It would be good if this could be included in the Python 3.11 final release, although I appreciate it's very late notice.

I should note that the new version of pip was just released this weekend, and if there are issues we could need to follow up with a bugfix release. While I hope there won't be any issues (there are no major changes in this release) obviously I can't guarantee that. I would be pushing hard for any such bugfix release to happen before next weekend, if one were needed. I don't know whether this possibility would affect your decision about including this patch (and/or any possible bugfix release) in 3.11 final, but I thought I should make you aware 🙂

I'll set up a backport to 3.11, for inclusion in 3.11.1, regardless.

@pablogsal
Copy link
Member

Thanks for checking with me! 👍

One thing that would help me evaluate the risk better is if you could walk me through what improvements or bugfixes are important to get into 11.0.0. Is there any security fix or similar?

@pfmoore
Copy link
Member Author

pfmoore commented Oct 16, 2022

There's no major changes in 22.3 that are critical. The main reason for bundling the latest version is to allow users to not have to upgrade pip immediately on installing Python or creating a venv. So it's mostly a "quality of life" improvement, in that sense. Having the bundled pip be out of date is far from unusual, but it feels off to release a new version of pip and then immediately release a Python version that has an out of date pip1.

The only security-related change is that this version of pip bundles the latest certifi, so the certificates we use are more up to date. That's arguably important, but I wouldn't over-emphasise it (after all, we don't rush pip releases every time certifi adds new certificates, so it'd be hypocritical for me to try to claim it's crucial here...)

Footnotes

  1. We are talking about trying to bring pip's release cycle better into line with Python's, but we didn't manage to make the change for this release.

@pfmoore
Copy link
Member Author

pfmoore commented Oct 16, 2022

One other question, just to make sure I don't mess anything up - if I merge this and then trigger a backport to 3.11, that will go onto the 3.11 branch ready for 3.11.1, won't it - it won't affect the release branch?

@warsaw
Copy link
Member

warsaw commented Oct 16, 2022

I went ahead and approved it, but you should also wait for @pablogsal 's approval.

@pfmoore
Copy link
Member Author

pfmoore commented Oct 18, 2022

@pablogsal A gentle reminder - am I OK to merge and backport this for 3.12/3.11.1 etc?

@pablogsal
Copy link
Member

@pablogsal A gentle reminder - am I OK to merge and backport this for 3.12/3.11.1 etc?

Apologies for the delay!

Yeah, doing the backport is ok. I am still thinking about including it in 3.11.0, but I think it makes sense.

@pfmoore pfmoore merged commit 9da5215 into python:main Oct 18, 2022
@pfmoore pfmoore deleted the pip-22.3 branch October 18, 2022 14:48
@pfmoore pfmoore added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Oct 18, 2022
@miss-islington
Copy link
Contributor

Thanks @pfmoore for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks @pfmoore for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-98399 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 18, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 18, 2022
(cherry picked from commit 9da5215)

Co-authored-by: Paul Moore <[email protected]>
@bedevere-bot
Copy link

GH-98400 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 18, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 18, 2022
(cherry picked from commit 9da5215)

Co-authored-by: Paul Moore <[email protected]>
@pfmoore
Copy link
Member Author

pfmoore commented Oct 18, 2022

I am still thinking about including it in 3.11.0, but I think it makes sense.

FWIW, we haven't had any major issues reported, so I'm (cautiously!) optimistic that we won't need a 22.3.1 bugfix release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants