gh-95656: Enable the sqlite3 load extension API in Windows build

[erlend-aasland]

• Issue: Enable sqlite extensions in the Windows build #95656

[erlend-aasland]

I'm not sure about backporting this. What do you say, Steve?

[erlend-aasland]

This API is not tested. Let's add a test while we're there.

[zooba]

Does this have a Python API to go with it? Is that currently unusable on every release? If so, let's backport.

[erlend-aasland]

Does this have a Python API to go with it?

Yes, it enables this API:

cpython/Modules/_sqlite/connection.c

Lines 1490 to 1525 in bdbadb9

	#ifdef PY_SQLITE_ENABLE_LOAD_EXTENSION
	/*[clinic input]
	_sqlite3.Connection.enable_load_extension as pysqlite_connection_enable_load_extension
	enable as onoff: bool(accept={int})
	/
	Enable dynamic loading of SQLite extension modules.
	[clinic start generated code]*/
	static PyObject *
	pysqlite_connection_enable_load_extension_impl(pysqlite_Connection *self,
	int onoff)
	/*[clinic end generated code: output=9cac37190d388baf input=5f00e93f7a9d3540]*/
	{
	int rc;
	if (PySys_Audit("sqlite3.enable_load_extension",
	"OO", self, onoff ? Py_True : Py_False) < 0) {
	return NULL;
	}
	if (!pysqlite_check_thread(self) || !pysqlite_check_connection(self)) {
	return NULL;
	}
	rc = sqlite3_enable_load_extension(self->db, onoff);
	if (rc != SQLITE_OK) {
	PyErr_SetString(self->OperationalError,
	"Error enabling load extension");
	return NULL;
	} else {
	Py_RETURN_NONE;
	}
	}

Is that currently unusable on every release? If so, let's backport.

Yes; ok.

[zooba]

Haha, yeah, good point. Backport for sure

[erlend-aasland]

Thanks, Steve!

[miss-islington]

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

[miss-islington]

Sorry, @erlend-aasland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 6a5104f4fa83ed08fe31f712757dddabfede394c 3.10

[bedevere-bot]

GH-95671 is a backport of this pull request to the 3.11 branch.

[erlend-aasland]

Aha... no backport to 3.10 is needed. I changed the #ifdef guard in 3.11, while Christian and I were updating configure.ac. So... this means I broke this for Windows builds in 3.11.

FTR, broken in gh-29434.