gh-94949: Disallow parsing parenthesised ctx mgr with old feature_version #94950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hauntsaninja
commented
Jul 18, 2022
•
hauntsaninja
commented
- Issue: ast.parse allows parenthesised context managers with old feature_version #94949
hauntsaninja
added
needs backport to 3.10
pablogsal
approved these changes
Jul 18, 2022
|
Thanks @hauntsaninja for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 18, 2022
…re_version (pythonGH-94950) * pythongh-94949: Disallow parsing parenthesised ctx manager with old feature_version * 📜🤖 Added by blurb_it. * Allow it with feature_version=(3, 9) as well Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> (cherry picked from commit 0daba82) Co-authored-by: Shantanu <[email protected]>
|
Sorry, @hauntsaninja and @pablogsal, I could not cleanly backport this to |
|
GH-94988 is a backport of this pull request to the 3.11 branch. |
@hauntsaninja Same thing as the other: can you do the manual backport? |
miss-islington
added a commit
that referenced
this pull request
Jul 18, 2022
…sion (GH-94950) * gh-94949: Disallow parsing parenthesised ctx manager with old feature_version * 📜🤖 Added by blurb_it. * Allow it with feature_version=(3, 9) as well Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> (cherry picked from commit 0daba82) Co-authored-by: Shantanu <[email protected]>
hauntsaninja
added a commit
to hauntsaninja/cpython
that referenced
this pull request
Jul 19, 2022
…d feature_version (pythonGH-94950) (cherry picked from commit 0daba82) Co-authored-by: Shantanu <[email protected]>
|
GH-94990 is a backport of this pull request to the 3.10 branch. |
|
@pablogsal Done! |
pablogsal
pushed a commit
that referenced
this pull request
Jul 19, 2022
…ure_version (GH-94950) (#94990) (cherry picked from commit 0daba82) Co-authored-by: Shantanu <[email protected]>
AlexWaygood
added a commit
to AlexWaygood/cpython
that referenced
this pull request
Feb 25, 2024
…ld feature_version (python#94950)" This reverts commit 0daba82.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.