docs: typing.Self, fix typo #94771
Merged
docs: typing.Self, fix typo #94771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxzhenzhera
requested review from
gvanrossum,
Fidget-Spinner and
JelleZijlstra
as code owners
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Fidget-Spinner
approved these changes
Jul 12, 2022
Fidget-Spinner
added
needs backport to 3.11
|
Could you update https://github.com/python/cpython/blob/main/Lib/typing.py#L572 too please? |
|
@Fidget-Spinner Oh, sorry, Didn't think about this. |
|
Thanks @maxzhenzhera for the PR, and @Fidget-Spinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 12, 2022
* fix typo - double spelled word 'use' * change methods names to the infinitive form (cherry picked from commit 90a6e56) Co-authored-by: Max Zhenzhera <[email protected]>
|
GH-94786 is a backport of this pull request to the 3.11 branch. |
|
@maxzhenzhera congrats on your first contribution to CPython! Looking forward to more contributions in the future. |
miss-islington
added a commit
that referenced
this pull request
Jul 12, 2022
* fix typo - double spelled word 'use' * change methods names to the infinitive form (cherry picked from commit 90a6e56) Co-authored-by: Max Zhenzhera <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple typo fixes, no issue was created.