Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-94694: Fix column offsets for multi-line method lookups #94697

Merged
merged 6 commits into from
Jul 10, 2022
Merged

GH-94694: Fix column offsets for multi-line method lookups #94697

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
937a3db
Add failing regression test
brandtbucher Jul 8, 2022
dd5a391
Fix invalid column math
brandtbucher Jul 8, 2022
ffd3413
Add additional tests for column locations
brandtbucher Jul 8, 2022
53ba444
blurb add
brandtbucher Jul 8, 2022
33dc4d8
Update comment
brandtbucher Jul 8, 2022
13c07ff
Feedback from code review
brandtbucher Jul 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
blurb add
  • Loading branch information
@brandtbucher
brandtbucher committed Jul 8, 2022
commit 53ba4445a038e3430b1f6609c167f973c943699d
4 changes: 4 additions & 0 deletions Misc/NEWS.d/next/Core and Builtins/2022-07-08-16-44-11.gh-issue-94694.VkL2CM.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Fix an issue that could cause code with multi-line method lookups to have
misleading or incorrect column offset information. In some cases (when
compiling a hand-built AST) this could have resulted in a hard crash of the
interpreter.