Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-94321: Document sqlite3.PrepareProtocol #94620

Merged
merged 5 commits into from
Jul 7, 2022
Merged

gh-94321: Document sqlite3.PrepareProtocol #94620

merged 5 commits into from
Jul 7, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 6, 2022 •
edited by bedevere-bot
Loading

@erlend-aasland erlend-aasland linked an issue Jul 6, 2022 that may be closed by this pull request
Document sqlite3.PrepareProtocol #94321
Closed
@erlend-aasland erlend-aasland added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes skip news docs Documentation in the Doc dir labels Jul 6, 2022
CAM-Gerlach
CAM-Gerlach requested changes Jul 7, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth adding a NEWS entry?

Modules/_sqlite/prepare_protocol.c Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
@erlend-aasland
Copy link
Contributor Author

Maybe worth adding a NEWS entry?

Yeah, I thought about that myself.

@erlend-aasland
Copy link
Contributor Author

FYI, I'm merging this later tonight.

@erlend-aasland erlend-aasland mentioned this pull request Jul 7, 2022
Closed
CAM-Gerlach
CAM-Gerlach reviewed Jul 7, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still a little confused—is sqlite3.PrepareProtocol a type of "Blob Object"? I assumed it wasn't, which motivated my suggested change to add its own section heading, since its currently under the "Blob Object" section. Just to confirm—I was mistaken about that?

@erlend-aasland
Copy link
Contributor Author

Aaaaah, I missed adding the header. Sorry!

CAM-Gerlach
CAM-Gerlach approved these changes Jul 7, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks @erlend-aasland !

@erlend-aasland erlend-aasland merged commit fb6dcca into python:main Jul 7, 2022
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the sqlite-doc-prepareprotocol branch July 7, 2022 22:33
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 7, 2022
@erlend-aasland @miss-islington
pythongh-94321: Document sqlite3.PrepareProtocol (pythonGH-94620)
41166c7 
(cherry picked from commit fb6dcca)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@miss-islington
Copy link
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker fb6dccae348b954d9f625031b54711a9a33da525 3.10

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 7, 2022
@bedevere-bot
Copy link

GH-94670 is a backport of this pull request to the 3.11 branch.

erlend-aasland added a commit to erlend-aasland/cpython that referenced this pull request Jul 7, 2022
@erlend-aasland
[3.10] pythongh-94321: Document sqlite3.PrepareProtocol (pythonGH-94620…
d168606 
…).

(cherry picked from commit fb6dcca)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
@bedevere-bot
Copy link

GH-94671 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 7, 2022
@erlend-aasland erlend-aasland mentioned this pull request Jul 7, 2022
Closed
miss-islington added a commit that referenced this pull request Jul 7, 2022
@miss-islington @erlend-aasland
gh-94321: Document sqlite3.PrepareProtocol (GH-94620)
c72001e 
(cherry picked from commit fb6dcca)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
erlend-aasland added a commit that referenced this pull request Jul 7, 2022
@erlend-aasland
[3.10] gh-94321: Document sqlite3.PrepareProtocol (GH-94620) (#94671)
797745e 
(cherry picked from commit fb6dcca)

Co-authored-by: Erlend Egeberg Aasland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees

@erlend-aasland erlend-aasland

Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document sqlite3.PrepareProtocol
4 participants
@erlend-aasland @miss-islington @bedevere-bot @CAM-Gerlach