gh-51511: Note that codecs.open()'s encoding parameter affects automatic conversion to binary mode #94370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion to binary mode
gvanrossum
approved these changes
Oct 21, 2022
|
Do you want me to merge it? What about backports? |
|
Yep looking to get them merged, and backports sound good, I'll add the labels for 3.10/3.11 (I usually let the merger decide since they're the ones doing the extra work there :). |
slateny
added
needs backport to 3.10
|
Thanks @slateny for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 21, 2022
…automatic conversion to binary mode (pythonGH-94370) (cherry picked from commit d9407b1) Co-authored-by: Stanley <[email protected]>
|
GH-98533 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 21, 2022
…automatic conversion to binary mode (pythonGH-94370) (cherry picked from commit d9407b1) Co-authored-by: Stanley <[email protected]>
|
GH-98534 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Oct 21, 2022
…tic conversion to binary mode (GH-94370) (cherry picked from commit d9407b1) Co-authored-by: Stanley <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Oct 21, 2022
…tic conversion to binary mode (GH-94370) (cherry picked from commit d9407b1) Co-authored-by: Stanley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#51511
Partially related: #54553
codecs.open docs
See
cpython/Lib/codecs.py
Lines 901 to 904 in bc7f6fc
Affected lines found by
grep 'always opened in binary' -r