Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-29957: change LBYL key lookup to dict.setdefault #938

Merged
merged 3 commits into from
Apr 2, 2017
Merged

bpo-29957: change LBYL key lookup to dict.setdefault #938

merged 3 commits into from
Apr 2, 2017

Commits on Apr 1, 2017

  1. change LBYL key lookup to dict.setdefault 

    The ``results`` was constructed as a defaultdict and we could simply
delete the check ``if key not in results``. However, I think it's safer
to use dict.setdefault as I'm not sure whether the caller expects a
regular dict or defaultdict.
    @selik
    selik committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    754b06d View commit details
    Browse the repository at this point in the history

  2. add name to the acknowledgements file

    @selik
    selik committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    fe504af View commit details
    Browse the repository at this point in the history

  3. use defaultdict to make the key-lookup cleaner

    @selik
    selik committed Apr 1, 2017
    Configuration menu
    Copy the full SHA
    39c253a View commit details
    Browse the repository at this point in the history