Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-92728: Restore re.template, but deprecate it #93161

Merged
merged 9 commits into from
May 25, 2022
Merged

gh-92728: Restore re.template, but deprecate it #93161

merged 9 commits into from
May 25, 2022

Conversation

hroncok
Copy link
Contributor

@hroncok hroncok commented May 24, 2022

No description provided.

@hroncok hroncok mentioned this pull request May 24, 2022
Closed
@hroncok hroncok marked this pull request as ready for review May 24, 2022 09:07
@hroncok
Copy link
Contributor Author

hroncok commented May 24, 2022

Considering the relevant function/flag was not documented, I have decided not to add a versionchanged thing to the documentation of the re module. Let me know if I should.

@serhiy-storchaka serhiy-storchaka self-requested a review May 24, 2022 09:25
serhiy-storchaka
serhiy-storchaka approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Lib/re/__init__.py Show resolved Hide resolved
Misc/NEWS.d/next/Library/2022-05-24-10-59-02.gh-issue-92728.zxTifq.rst Show resolved Hide resolved
@hroncok
Copy link
Contributor Author

hroncok commented May 24, 2022

Could you please label this with 3.11 backport?

hroncok
hroncok commented May 24, 2022
View reviewed changes
Lib/test/test_re.py Outdated Show resolved Hide resolved
@serhiy-storchaka serhiy-storchaka added the 3.11 only security fixes label May 25, 2022
@serhiy-storchaka serhiy-storchaka merged commit 16a7e4a into python:main May 25, 2022
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes and removed 3.11 only security fixes labels May 25, 2022
@miss-islington
Copy link
Contributor

Thanks @hroncok for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 25, 2022
@hroncok @miss-islington
pythongh-92728: Restore re.template, but deprecate it (pythonGH-93161)
f191b17 
Revert "bpo-47211: Remove function re.template() and flag re.TEMPLATE (pythonGH-32300)"

This reverts commit b09184b.
(cherry picked from commit 16a7e4a)

Co-authored-by: Miro Hrončok <[email protected]>
@bedevere-bot
Copy link

GH-93206 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label May 25, 2022
miss-islington added a commit that referenced this pull request May 25, 2022
@miss-islington @hroncok
gh-92728: Restore re.template, but deprecate it (GH-93161)
74b205b 
Revert "bpo-47211: Remove function re.template() and flag re.TEMPLATE (GH-32300)"

This reverts commit b09184b.
(cherry picked from commit 16a7e4a)

Co-authored-by: Miro Hrončok <[email protected]>
@hroncok hroncok deleted the dont_break_compatibility branch May 25, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hroncok @miss-islington @bedevere-bot @serhiy-storchaka