gh-92984 The Windows build of Python does not need incremental linker support for release and PGO builds #92985
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
|
For the NEWS entry (which you can create by running |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
Thanks for pointing me to that script. That was pretty easy to run and is now included. |
|
I'm going to run a test release build with this before backporting, just to be sure nothing breaks. But ILK should've been off anyway because of LTCG, so nothing should actually change. |
zooba
added
needs backport to 3.10
|
GH-92990 is a backport of this pull request to the 3.10 branch. |
…lease and PGO builds (pythonGH-92985) (cherry picked from commit 38feffa) Co-authored-by: David Machaj <[email protected]>
|
GH-92991 is a backport of this pull request to the 3.11 branch. |
…lease and PGO builds (pythonGH-92985) (cherry picked from commit 38feffa) Co-authored-by: David Machaj <[email protected]>
…and PGO builds (GH-92985) (cherry picked from commit 38feffa) Co-authored-by: David Machaj <[email protected]>
…and PGO builds (GH-92985) (cherry picked from commit 38feffa) Co-authored-by: David Machaj <[email protected]>
Closes #92984
This PR disables the incremental linker option for Windows builds when compiling Release or PGO. This configuration change equates to the /INCREMENTAL:NO linker option.
Debug builds were not changed. Incremental linking is more likely to be useful there.
This change was tested by compiling the project using
pcbuild/build.bat --pgo. When run on themainbranch with no changes the resulting binaries could not be analyzed in some tools because of incremental linking (even though it wasn't actually incremental). After this change and a recompile of everything the resulting binary could be analyzed.