Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import sys in test_threading_local.py for line 144 #8049

Merged
merged 1 commit into from
Jan 6, 2019

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 2, 2018

sys is used on line 144 but it is never imported.

__sys__ is used on line 144 but it is never imported.
@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again for your contribution, we look forward to reviewing it!

@cclauss
Copy link
Contributor Author

cclauss commented Jul 2, 2018

CLA signed

@vstinner
Copy link
Member

vstinner commented Jul 3, 2018

CLA signed

Did you fill your GitHub login in your bugs.python.org account? If yes, it seems like we have to wait until someone review your signature (it's a manual process).

@cclauss
Copy link
Contributor Author

cclauss commented Dec 22, 2018

@vstinner @Mariatta I have signed the CLA now... Can you please try this again or should I create a new PR?

@Mariatta
Copy link
Member

You can check CLA status here: https://check-python-cla.herokuapp.com
In addition you should also have bpo account and enter your GitHub account there.

@cclauss
Copy link
Contributor Author

cclauss commented Dec 23, 2018

check-python-cla says my email address has signed the CLA but my GitHub ID has not but then it says my email address has no bpo account but my GitHub ID does. I have tried several combinations and permutations. cclauss should be both a CLA signatory and a bpo user but check-python-cla does not agree. :-(

@Mariatta
Copy link
Member

What is your bpo username?

@cclauss
Copy link
Contributor Author

cclauss commented Dec 23, 2018

cclauss (User30167)

@Mariatta
Copy link
Member

screenshot_20181224-091650 2

In bpo it still shows that the CLA is not yet received. It might take another US business day.

@miss-islington
Copy link
Contributor

Thanks @cclauss for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@vstinner
Copy link
Member

vstinner commented Jan 6, 2019

Thanks, I merged your PR. But I rewrote the commit message.

@bedevere-bot
Copy link

GH-11450 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2019
miss-islington added a commit that referenced this pull request Jan 6, 2019
(cherry picked from commit a0bb51e)

Co-authored-by: cclauss <[email protected]>
@cclauss cclauss deleted the patch-1 branch January 6, 2019 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants