bpo-33807: Add Python 3.7 to .github/CONTRIBUTING.rst #7532
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. When your account is ready, please add a comment in this pull request Thanks again to your contribution and we look forward to looking at it! |
|
✅ Ok. I filled out and signed the PSF contributor form. We need to wait at least one US business day to ask for a CLA recheck. |
.github/CONTRIBUTING.rst
Outdated
| @@ -6,7 +6,7 @@ Build Status | |||
|
|
|||
| - master | |||
|
|
|||
| + `Stable buildbots <http://buildbot.python.org/3.x.stable/>`_ | |||
| + `Stable buildbots <http://buildbot.python.org/all/#/masters/>`_ | |||
There was a problem hiding this comment.
I think the correct link is either http://buildbot.python.org/all/#/grid?branch=master&tag=stable or http://buildbot.python.org/all/#/builders?tags=%2Bstable&tags=%2B3.x
@zware which one is better?
There was a problem hiding this comment.
"better" is a pure judgement call, unfortunately. I prefer the builders page, but I believe others prefer the grid page. The grid page does at least attempt to match up builds with commits, so that one may actually be better.
.github/CONTRIBUTING.rst
Outdated
| @@ -6,7 +6,7 @@ Build Status | |||
|
|
|||
| - master | |||
|
|
|||
| + `Stable buildbots <http://buildbot.python.org/3.x.stable/>`_ | |||
| + `Stable buildbots <http://buildbot.python.org/all/#/masters/>`_ | |||
|
|
|||
| - 3.6 | |||
There was a problem hiding this comment.
You also need to fix the links of 3.6 and 2.7 branches.
There was a problem hiding this comment.
@berkerpeksag 👍 Yes. I didn't find links that matches.
.github/CONTRIBUTING.rst
Outdated
| @@ -6,7 +6,7 @@ Build Status | |||
|
|
|||
| - master | |||
|
|
|||
| + `Stable buildbots <http://buildbot.python.org/3.x.stable/>`_ | |||
| + `Stable buildbots <http://buildbot.python.org/all/#/masters/>`_ | |||
There was a problem hiding this comment.
"better" is a pure judgement call, unfortunately. I prefer the builders page, but I believe others prefer the grid page. The grid page does at least attempt to match up builds with commits, so that one may actually be better.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
@zware 👍 Ok. I'm going to add |
suriyaa
changed the title
|
@zware I updated the pull request (change pr title & rebase Git commits). |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @zware: please review the changes made to this pull request. |
|
|
😁
|
Thanks @SuriyaaKudoIsc for the PR, and @zware for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
|
@SuriyaaKudoIsc Thanks for your contribution! |
…pythonGH-7532) (cherry picked from commit 9e6685e) Co-authored-by: Suriyaa ✌️️ <[email protected]>
|
GH-7540 is a backport of this pull request to the 3.7 branch. |
…GH-7532) (cherry picked from commit 9e6685e) Co-authored-by: Suriyaa ✌️️ <[email protected]>
Hello @python community,
This is my first Python pull request! 😄
This solves
bpo-33807: https://bugs.python.org/issue33807.--Suriyaa Sundararuban (My Python profile) (My Bugs Profile)
https://bugs.python.org/issue33807