Fix typo in error message when decoding PYTHONPATH. #6981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @vstinner |
|
Also cc @ned-deily in case you want to consider this for 3.7. It is a regression in 3.7; if PYTHONPATH can’t be decoded in the current locale, the error message will mention the wrong env var (PYTHONHOME instead of PYTHONPATH), which could send someone on a confusing wild goose chase. |
willingc
approved these changes
May 19, 2018
|
Thanks @carljm for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 19, 2018
(cherry picked from commit 4857543) Co-authored-by: Carl Meyer <[email protected]>
|
GH-6993 is a backport of this pull request to the 3.7 branch. |
ned-deily
pushed a commit
that referenced
this pull request
May 19, 2018
(cherry picked from commit 4857543) Co-authored-by: Carl Meyer <[email protected]>
|
Oh. Thanks for the fix :-) My code requires to repeat the same variable name 3 times, it's very error prone, but I failed to design a simpler C API to avoid to repeat myself ;-) The current code is simple enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a simple typo that slipped through in 46972b7.