-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Windows build of Python for latest WinSDK. #6874
Conversation
The Travis CI failure appears to be spurious; this PR doesn't contain any changes that would affect a non-Windows build. I can add a bugs.python.org issue if that's needed; wasn't sure if this build-system fix met the triviality bar or not. I don't think a news entry should be needed here, but I don't have permission to add the "skip news" label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sorry for not seeing this earlier
(cherry picked from commit c0ee341) Co-authored-by: Carl Meyer <[email protected]>
GH-6952 is a backport of this pull request to the 3.7 branch. |
Sorry, @carljm and @zooba, I could not cleanly backport this to |
GH-6953 is a backport of this pull request to the 3.6 branch. |
(cherry picked from commit c0ee341) Co-authored-by: Carl Meyer <[email protected]>
Python would not build on a fresh Windows machine with a fresh Visual Studio install. Per @zooba this is because there is a new version of the Windows SDK bundled with latest VS. This issue would not affect anyone upgrading earlier VS versions, only a fresh install.
Confirmed that this fix allows
PCBuild/build.bat
to complete instead of failing to find the Win SDK.