Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33430: import secrets module in secrets recipes #6705

Merged
merged 1 commit into from
May 19, 2018
Merged

bpo-33430: import secrets module in secrets recipes #6705

merged 1 commit into from
May 19, 2018

Conversation

chimeno
Copy link

@chimeno chimeno commented May 5, 2018

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again to your contribution and we look forward to looking at it!

@chimeno
Copy link
Author

chimeno commented May 5, 2018

CLA signed

@tiran
Copy link
Member

tiran commented May 14, 2018

LGTM

@stevendaprano are you fine with the change, too?

Copy link
Member

@stevendaprano stevendaprano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me too, thanks.

@stevendaprano stevendaprano merged commit cf8abcb into python:master May 19, 2018
@bedevere-bot
Copy link

@stevendaprano: Please replace # with GH- in the commit message next time. Thanks!

@chimeno chimeno deleted the fix-issue-33430 branch May 19, 2018 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants