-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-28810: Update lnotab_notes.txt #665
Conversation
@ilevkivskyi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @avassalotti to be a potential reviewer. |
Objects/lnotab_notes.txt
Outdated
@@ -45,7 +45,8 @@ above example contains two such values. So we make two tweaks: | |||
line_incr -= 0x100 | |||
lineno += line_incr | |||
|
|||
(In C, this is implemented by PyCode_Addr2Line().) In order for this to work, | |||
(In C, this is implemented by PyCode_Addr2Line(). Note that before 3.6, only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use two spaces between sentences.
I think that the better place for this note is few lines above, when describe the range of line_incr
.
The line
doesn't look correct (the maximal And while we are here please change "Python string" to "bytes object" (or "Python bytes object"). |
Ah, and while we are here, please fix tabs used instead of spaces. |
Fixed. I have found only three lines with tabs in this file. |
(cherry picked from commit 9135275)
@serhiy-storchaka @brettcannon Here is the separate PR for
lnotab_notes.txt
that I promised.This needs to be backported to 3.6.