Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-33370: Add .mypy_cache to .gitignore #6623

Closed
wants to merge 1 commit into from
Closed

bpo-33370: Add .mypy_cache to .gitignore #6623

wants to merge 1 commit into from

Conversation

cypher-naman
Copy link

@cypher-naman cypher-naman commented Apr 28, 2018

Added .mypy_cache to .gitignore

Mentored by @CuriousLearner

https://bugs.python.org/issue33370

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

When your account is ready, please add a comment in this pull request
and a Python core developer will remove the CLA not signed label
to make the bot check again.

Thanks again to your contribution and we look forward to looking at it!

@matrixise
Copy link
Member

I am sorry, but I don't see why we need to have .mypy_cache in the .gitignore file...

As @brettcannon has said, you have to modify your global .gitignore and not the .gitignore of this project.

Have a nice day,

@ethanhs
Copy link
Contributor

ethanhs commented Apr 29, 2018

There is already an open PR here that passes CI #6614. I also don't understand why this is needed?

@brettcannon
Copy link
Member

Closing this as a duplicate of #6614.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants