Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-22069: Flush is implied also when write contains a carriage return #6609

Merged
merged 1 commit into from
May 14, 2018
Merged

bpo-22069: Flush is implied also when write contains a carriage return #6609

merged 1 commit into from
May 14, 2018

Conversation

elenaoat
Copy link
Contributor

@elenaoat elenaoat commented Apr 26, 2018 •
edited by bedevere-bot
Loading

@matrixise
Copy link
Member

Thank you for your patch,

@Mariatta Mariatta merged commit 7ffd4c5 into python:master May 14, 2018
@miss-islington
Copy link
Contributor

Thanks @elenaoat for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 2.7, 3.6, 3.7.
🐍🍒⛏🤖

@Mariatta
Copy link
Member

Thanks @elenaoat 🌮

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 14, 2018
@elenaoat @miss-islington
bpo-22069: Update TextIO documentation (pythonGH-6609)
89d6835 
Clarify that flush is implied when the call to write contains a newline character.
(cherry picked from commit 7ffd4c5)

Co-authored-by: Elena Oat <[email protected]>
@bedevere-bot
Copy link

GH-6801 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-6802 is a backport of this pull request to the 2.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 14, 2018
@elenaoat @miss-islington
bpo-22069: Update TextIO documentation (pythonGH-6609)
bda1cc5 
Clarify that flush is implied when the call to write contains a newline character.
(cherry picked from commit 7ffd4c5)

Co-authored-by: Elena Oat <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 14, 2018
@elenaoat @miss-islington
bpo-22069: Update TextIO documentation (pythonGH-6609)
81b20c1 
Clarify that flush is implied when the call to write contains a newline character.
(cherry picked from commit 7ffd4c5)

Co-authored-by: Elena Oat <[email protected]>
@bedevere-bot
Copy link

GH-6803 is a backport of this pull request to the 3.6 branch.

miss-islington added a commit that referenced this pull request May 14, 2018
@miss-islington @elenaoat
bpo-22069: Update TextIO documentation (GH-6609)
050e041 
Clarify that flush is implied when the call to write contains a newline character.
(cherry picked from commit 7ffd4c5)

Co-authored-by: Elena Oat <[email protected]>
miss-islington added a commit that referenced this pull request May 14, 2018
@miss-islington @elenaoat
bpo-22069: Update TextIO documentation (GH-6609)
84fc6c5 
Clarify that flush is implied when the call to write contains a newline character.
(cherry picked from commit 7ffd4c5)

Co-authored-by: Elena Oat <[email protected]>
miss-islington added a commit that referenced this pull request May 14, 2018
@miss-islington @elenaoat
bpo-22069: Update TextIO documentation (GH-6609)
9fd5b5f 
Clarify that flush is implied when the call to write contains a newline character.
(cherry picked from commit 7ffd4c5)

Co-authored-by: Elena Oat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matrixise matrixise matrixise approved these changes

@Mariatta Mariatta Mariatta approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@elenaoat @matrixise @miss-islington @Mariatta @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni