Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-33169: Remove values of None from sys.path_importer_cache when invalidating caches #6402

Merged
merged 5 commits into from
Apr 6, 2018
Merged

bpo-33169: Remove values of None from sys.path_importer_cache when invalidating caches #6402

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f1bf025
Clear out None entries in sys.path.importer_cache
brettcannon Apr 6, 2018
e2eac8f
Tests for importlib.machinery.PathFinder.invalidate_caches()
brettcannon Apr 6, 2018
b5801ed
Add a news entry
brettcannon Apr 6, 2018
40e5fa6
Document the change
brettcannon Apr 6, 2018
b856270
Make a key removal optional
brettcannon Apr 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tests for importlib.machinery.PathFinder.invalidate_caches()
  • Loading branch information
@brettcannon
brettcannon committed Apr 6, 2018
commit e2eac8ff6b07f5ce977a175e1982f2dbe326359c
21 changes: 21 additions & 0 deletions Lib/test/test_importlib/import_/test_path.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,27 @@ def test_deleted_cwd(self):
# Do not want FileNotFoundError raised.
self.assertIsNone(self.machinery.PathFinder.find_spec('whatever'))

def test_invalidate_caches_finders(self):
# Finders with an invalidate_caches() method have it called.
class FakeFinder:
def __init__(self):
self.called = False

def invalidate_caches(self):
self.called = True

cache = {'leave_alone': object(), 'finder_to_invalidate': FakeFinder()}
with util.import_state(path_importer_cache=cache):
self.machinery.PathFinder.invalidate_caches()
self.assertTrue(cache['finder_to_invalidate'].called)

def test_invalidate_caches_clear_out_None(self):
# Clear out None in sys.path_importer_cache() when invalidating caches.
cache = {'clear_out': None}
with util.import_state(path_importer_cache=cache):
self.machinery.PathFinder.invalidate_caches()
self.assertEqual(len(cache), 0)


class FindModuleTests(FinderTests):
def find(self, *args, **kwargs):
Expand Down