bpo-30940: Updating round() docs. #6342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doc/library/functions.rst
Outdated
| @@ -1331,11 +1331,11 @@ are always available. They are listed here in alphabetical order. | |||
| equally close, rounding is done toward the even choice (so, for example, | |||
| both ``round(0.5)`` and ``round(-0.5)`` are ``0``, and ``round(1.5)`` is | |||
| ``2``). Any integer value is valid for *ndigits* (positive, zero, or | |||
| negative). The return value is an integer if called with one argument, | |||
| otherwise of the same type as *number*. | |||
| negative). The return value is an integer if *ndigits* is omitted or *None*. | |||
There was a problem hiding this comment.
It usually is formatted as ``None``.
matrixise
approved these changes
May 14, 2018
There was a problem hiding this comment.
Hi @lisroach, thank you for your PR, it's really appreciated and you have upgraded your PR with the recommendation of @serhiy-storchaka. Thank you.
|
@mdickinson, could you please make a look? |
|
@serhiy-storchaka Would you mind merging? I'm not confident that I have the backport process down yet. Thanks. |
|
Thanks @lisroach for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 20, 2018
(cherry picked from commit 900c48d) Co-authored-by: Lisa Roach <[email protected]>
|
GH-7009 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 20, 2018
(cherry picked from commit 900c48d) Co-authored-by: Lisa Roach <[email protected]>
|
GH-7010 is a backport of this pull request to the 3.6 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
May 20, 2018
(cherry picked from commit 900c48d) Co-authored-by: Lisa Roach <[email protected]>
miss-islington
added a commit
that referenced
this pull request
May 20, 2018
(cherry picked from commit 900c48d) Co-authored-by: Lisa Roach <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the round docs to make it more clear what happens when None is the second argument to round().
https://bugs.python.org/issue30940