Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32703: Fix coroutine resource warning in case where there's an error #5410

Merged
merged 2 commits into from
Jan 29, 2018
Merged

bpo-32703: Fix coroutine resource warning in case where there's an error #5410

merged 2 commits into from
Jan 29, 2018

Conversation

1st1
Copy link
Member

@1st1 1st1 commented Jan 29, 2018 •
edited
Loading

@njsmith
Copy link
Contributor

njsmith commented Jan 29, 2018

This is effectively a reversion of @benjaminp's fix for bpo-27968 so CC'ing @benjaminp.

Otherwise LGTM though it could use a test.

@1st1
Copy link
Member Author

1st1 commented Jan 29, 2018

Otherwise LGTM though it could use a test.

Yes, it needs a test and also to properly silence test_coroutines. Will work on this PR to finish it a bit later.

@1st1 1st1 merged commit 2a2270d into python:master Jan 29, 2018
@1st1 1st1 deleted the fixcoro branch January 29, 2018 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@1st1 @njsmith @the-knights-who-say-ni @bedevere-bot