Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32384 fix test.test_generators for other implementations #4940

Merged
merged 2 commits into from
May 16, 2018
Merged

bpo-32384 fix test.test_generators for other implementations #4940

merged 2 commits into from
May 16, 2018

Conversation

isaiah
Copy link
Contributor

@isaiah isaiah commented Dec 20, 2017 •
edited by bedevere-bot
Loading

Added guard to the test.test_generators.SignalAndYieldFromTest to check the existence of _testcapi.raise_SIGINT_then_send_None

https://bugs.python.org/issue32384

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@bitdancer bitdancer requested a review from 1st1 December 20, 2017 14:35
@1st1 1st1 added the skip news label Dec 20, 2017
@1st1
Copy link
Member

1st1 commented Dec 20, 2017

Approved. Please sign the CLA and I'll merge this.

1st1
1st1 requested changes Dec 24, 2017
View reviewed changes
Lib/test/test_generators.py Outdated


# This tests to make sure that if a SIGINT arrives just before we send into a
# yield from chain, the KeyboardInterrupt is raised in the innermost
# generator (see bpo-30039).
@unittest.skipUnless(_testcapi is not None and hasattr(_testcapi,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move hasattr on a new line.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@isaiah
Copy link
Contributor Author

isaiah commented Dec 27, 2017

@1st1 Thanks for your review, I've fixed the style. Just noticed that the CLA robot only checks if there are new commits, because I've signed the CLA after the PR is created.

@berkerpeksag berkerpeksag mentioned this pull request May 16, 2018
Closed
berkerpeksag
berkerpeksag approved these changes May 16, 2018
View reviewed changes
Copy link
Member

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and all of Yury's review comments have been addressed.

@berkerpeksag berkerpeksag merged commit 4cc3eb4 into python:master May 16, 2018
@miss-islington
Copy link
Contributor

Thanks @isaiah for the PR, and @berkerpeksag for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 16, 2018
@isaiah @miss-islington
bpo-32384: Skip test when _testcapi isn't available (pythonGH-4940)
0c0648b 
(cherry picked from commit 4cc3eb4)

Co-authored-by: Isaiah Peng <[email protected]>
@bedevere-bot
Copy link

GH-6891 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 16, 2018
@isaiah @miss-islington
bpo-32384: Skip test when _testcapi isn't available (pythonGH-4940)
85f0252 
(cherry picked from commit 4cc3eb4)

Co-authored-by: Isaiah Peng <[email protected]>
@bedevere-bot
Copy link

GH-6892 is a backport of this pull request to the 3.6 branch.

berkerpeksag pushed a commit that referenced this pull request May 16, 2018
@miss-islington @isaiah @berkerpeksag
bpo-32384: Skip test when _testcapi isn't available (GH-4940)
4af6110 
(cherry picked from commit 4cc3eb4)

Co-authored-by: Isaiah Peng <[email protected]>
berkerpeksag pushed a commit that referenced this pull request May 16, 2018
@miss-islington @isaiah @berkerpeksag
bpo-32384: Skip test when _testcapi isn't available (GH-4940)
5e8c526 
(cherry picked from commit 4cc3eb4)

Co-authored-by: Isaiah Peng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1 1st1 requested changes

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@isaiah @the-knights-who-say-ni @1st1 @bedevere-bot @miss-islington @berkerpeksag