F-strings docs: fixing link to Format Specifiers #4931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mariatta
reviewed
Dec 19, 2017
Doc/reference/lexical_analysis.rst
Outdated
| :ref:`format specifiers <formatspec>`, but may not include more | ||
| deeply-nested replacement fields. | ||
| Top-level format specifiers may include nested replacement fields. These nested | ||
| fields may include their own conversion fields and format specifiers, but may |
There was a problem hiding this comment.
This mention of format specifiers should still be linked like before.
|
Thanks @KatherineMichel for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 19, 2017
Mention that the format-specifier mini language in f-strings is the same one used by str.format. (cherry picked from commit f4e21a2)
|
GH-4933 is a backport of this pull request to the 3.6 branch. |
|
Thanks @KatherineMichel 🌮 |
|
Woohoo congrats taco! @Mariatta |
Mariatta
pushed a commit
that referenced
this pull request
Dec 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting this PR to amend f-string docs update made by Mariatta: https://github.com/python/cpython/pull/4888/files#r157292842