bpo-32348: Optimize asyncio.Future schedule/add/remove callback. #4907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After the change C future has |
|
I actually want to keep Python implementation simple (for educational purposes) and different (to catch any difference in semantics). |
|
Got it. Ok. |
asvetlov
approved these changes
Dec 17, 2017
methane
reviewed
Dec 17, 2017
Modules/_asynciomodule.c
Outdated
| } | ||
| else { | ||
| assert(fut->fut_callback0 != NULL); | ||
| assert(fut->fut_callbacks == NULL); |
There was a problem hiding this comment.
These asserts seems too redundant.
methane
reviewed
Dec 17, 2017
Modules/_asynciomodule.c
Outdated
| #define FI_FREELIST_MAXLEN 100 | ||
| static futureiterobject *fi_freelist_head = NULL; | ||
| static futureiterobject *fi_freelist_tail = NULL; | ||
| static Py_ssize_t fi_freelist_len = 0; |
There was a problem hiding this comment.
I recommend LIFO than FIFO when implementing freelist.
It may be better CPU cache ratio.
methane
approved these changes
Dec 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32348