Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-28393: Update encoding lookup docs wrt bpo-27938 #4871

Merged
merged 2 commits into from
Dec 15, 2017
Merged

bpo-28393: Update encoding lookup docs wrt bpo-27938 #4871

merged 2 commits into from
Dec 15, 2017

Conversation

scop
Copy link
Contributor

@scop scop commented Dec 14, 2017 •
edited by bedevere-bot
Loading

vstinner
vstinner requested changes Dec 15, 2017
View reviewed changes
Doc/library/codecs.rst Outdated
the same using underscores instead of dashes. Using alternative
aliases for these encodings may result in slower execution.

.. versionadded:: 3.6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

versionchanged would be more appropriate here.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@scop
Copy link
Contributor Author

scop commented Dec 15, 2017

I have made the requested changes; please review again.

@bedevere-bot
Copy link

Thanks for making the requested changes!

@vstinner: please review the changes made to this pull request.

@vstinner vstinner merged commit 297fd87 into python:master Dec 15, 2017
@miss-islington
Copy link
Contributor

Thanks @scop for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 15, 2017
@scop @miss-islington
bpo-28393: Update encoding lookup docs wrt bpo-27938 (pythonGH-4871)
0e14b2d 
(cherry picked from commit 297fd87)
@bedevere-bot
Copy link

GH-4881 is a backport of this pull request to the 3.6 branch.

@scop scop deleted the bpo-28393 branch December 15, 2017 11:01
vstinner pushed a commit that referenced this pull request Dec 15, 2017
@miss-islington @vstinner
bpo-28393: Update encoding lookup docs wrt bpo-27938 (GH-4871) (#4881)
77bf6da 
(cherry picked from commit 297fd87)
@serhiy-storchaka serhiy-storchaka mentioned this pull request Apr 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner requested changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@scop @bedevere-bot @miss-islington @vstinner @the-knights-who-say-ni