Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32255: Fix inconsistent behavior when csv.writer writes None #4769

Merged
merged 6 commits into from
Dec 12, 2017
Merged

bpo-32255: Fix inconsistent behavior when csv.writer writes None #4769

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f547e72
bpo-32255: Fix inconsistent behavior when csv.writer writes None
Licht-T Dec 11, 2017
93d4dd1
bpo-32255: Add tests for csv.writer
Licht-T Dec 11, 2017
2a6feb4
bpo-32255: Fix PEP 8 lint issue
Licht-T Dec 11, 2017
3f36bce
bpo-32255: Add name into Misc/ACKS
Licht-T Dec 11, 2017
c76ab64
bpo-32255: Add Misc/NEWS.d/ entry
Licht-T Dec 11, 2017
24037b1
Update 2017-12-12-07-29-06.bpo-32255.2bfNmM.rst
serhiy-storchaka Dec 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bpo-32255: Fix PEP 8 lint issue
  • Loading branch information
@Licht-T
Licht-T committed Dec 11, 2017
commit 2a6feb46b5a61561ece39d6f549c1266842209a6
8 changes: 4 additions & 4 deletions Lib/test/test_csv.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,26 +207,26 @@ def write(self, buf):
with TemporaryFile("w+", newline='') as fileobj:
writer = csv.writer(fileobj)
self.assertRaises(TypeError, writer.writerows, None)
writer.writerows([['a','b'],['c','d']])
writer.writerows([['a', 'b'], ['c', 'd']])
fileobj.seek(0)
self.assertEqual(fileobj.read(), "a,b\r\nc,d\r\n")

def test_writerows_with_none(self):
with TemporaryFile("w+", newline='') as fileobj:
writer = csv.writer(fileobj)
writer.writerows([['a',None],[None,'d']])
writer.writerows([['a', None], [None, 'd']])
fileobj.seek(0)
self.assertEqual(fileobj.read(), "a,\r\n,d\r\n")

with TemporaryFile("w+", newline='') as fileobj:
writer = csv.writer(fileobj)
writer.writerows([[None],['a']])
writer.writerows([[None], ['a']])
fileobj.seek(0)
self.assertEqual(fileobj.read(), '""\r\na\r\n')

with TemporaryFile("w+", newline='') as fileobj:
writer = csv.writer(fileobj)
writer.writerows([['a'],[None]])
writer.writerows([['a'], [None]])
fileobj.seek(0)
self.assertEqual(fileobj.read(), 'a\r\n""\r\n')

Expand Down