Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Guido and Ivan as owners for typing.py #4729

Merged
merged 2 commits into from
Dec 5, 2017
Merged

Add Guido and Ivan as owners for typing.py #4729

merged 2 commits into from
Dec 5, 2017

Conversation

gvanrossum
Copy link
Member

ilevkivskyi
ilevkivskyi reviewed Dec 5, 2017
View reviewed changes
.github/CODEOWNERS Outdated
@@ -51,3 +51,5 @@ Python/bootstrap_hash.c @python/crypto-team
**/*decimal* @rhettinger @skrah

**/*idlelib* @terryjreedy

**/*typing* @gvanrossum @ilevkivslyi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the PR! There is a small typo: it should be @ilevkivskyi (the third letter from the end should be k, not l).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dang. And I was trying to be so careful! :-) Fixed now.

@ned-deily ned-deily merged commit 5e8cbcc into master Dec 5, 2017
@ned-deily ned-deily deleted the typing-owners branch December 5, 2017 21:56
@miss-islington
Copy link
Contributor

Thanks @gvanrossum for the PR, and @ned-deily for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @gvanrossum and @ned-deily, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 5e8cbcc4f25dcdc02651414f792dc4a546ba199b 3.6

@Mariatta
Copy link
Member

Mariatta commented Dec 5, 2017

Codeowners is only in master branch. Do we need it in the other branches?

@gvanrossum
Copy link
Member Author

Let's not.

@ned-deily
Copy link
Member

Having it only with master is fine with me, I didn't realize it was only there. So no backport needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilevkivskyi ilevkivskyi ilevkivskyi approved these changes

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@gvanrossum @miss-islington @Mariatta @ned-deily @ilevkivskyi @the-knights-who-say-ni @bedevere-bot