bpo-32059: detect_modules() in setup.py now also searches the sysroot… #4452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… paths when cross-compiling
xdegaye
added
needs backport to 3.6
type-bug
When cross-compiling the sysconfig module uses the newly built sysconfigdata file since setup.py is run with the _PYTHON_SYSCONFIGDATA_NAME environment variable set to its file name (see 92dec54).
|
Thanks @xdegaye for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
|
GH-4562 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 25, 2017
detect_modules() in setup.py now also searches the sysroot paths when cross-compiling. (cherry picked from commit 77f5139)
xdegaye
pushed a commit
that referenced
this pull request
Nov 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… paths when cross-compiling
https://bugs.python.org/issue32059