Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-31304: Corrected typo in the documentation of multiprocessing.pool.Pool.starmap #4168

Merged
merged 1 commit into from
Oct 30, 2017

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Oct 29, 2017

From the issue:

The documentation suggests that multiprocessing.pool.Pool. starmap_async has a kwarg called 'error_back', but it actually has a kwarg called 'error_callback' to handle errors, just like map_async.

https://bugs.python.org/issue31304

@pablogsal pablogsal changed the title bpo-31304: Corrected typo in the documentation of multiprocessing.pool.Pool.star… bpo-31304: Corrected typo in the documentation of multiprocessing.pool.Pool.starmap Oct 29, 2017
Copy link
Contributor

@diekmann diekmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function definition
def starmap_async(self, func, iterable, chunksize=None, callback=None, error_callback=None):
from https://github.com/python/cpython/blob/master/Lib/multiprocessing/pool.py#L278

Your change looks good to me.

@Mariatta Mariatta merged commit 1122575 into python:master Oct 30, 2017
@miss-islington
Copy link
Contributor

Thanks @pablogsal for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 30, 2017
Update the kwarg in the documentation of `multiprocessing.pool.Pool.starmap_async`, from `error_back` to `error_callback` to match the source code..
(cherry picked from commit 1122575)
@bedevere-bot
Copy link

GH-4177 is a backport of this pull request to the 3.6 branch.

Mariatta pushed a commit that referenced this pull request Oct 30, 2017
Update the kwarg in the documentation of `multiprocessing.pool.Pool.starmap_async`, from `error_back` to `error_callback` to match the source code.
(cherry picked from commit 1122575)
embray pushed a commit to embray/cpython that referenced this pull request Nov 9, 2017
Update the kwarg in the documentation of `multiprocessing.pool.Pool.starmap_async`, from `error_back` to `error_callback` to match the source code..
@pablogsal pablogsal deleted the bpo31304 branch May 19, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants